Todd Baert

Results 47 comments of Todd Baert

@justinabrahms I made a similar comment in your recent PR: https://github.com/open-feature/spec/pull/31/files . I'll repeat it here: > While I see the distinction you're making between the flag value and the...

I think we might want to consider hashing strings. A few vendors specify strings in the 3000 byte range are possible as flag values - I think we should consider...

> Is a byte array possible in any of these systems? Maybe good to include just for future-proofing I haven't see byte array support from any existing vendor SDKs. A...

:100: , couldn't agree more. This is related to https://github.com/open-feature/spec/issues/77. This will become very important when we expose events on the OpenFeature client API. This is a major new feature...

I'd like to see an OFEP for this at some point, but it's not pressing. I'm leaving this open for now.

This needs a thorough OFEP, eventually.

We might want to update this point not to be prescriptive of the actual `error codes`, to be consistent with: https://github.com/open-feature/spec/blob/main/specification/flag-evaluation/flag-evaluation.md#requirement-147 > It sounds like the thing is saying "If...

I mentioned this in a previous PR... I'm not sure I agree. This doesn't really have much to do with hooks - it's really about setting context at various levels....

Maybe we could just have a link in the non-normative section of 3.2.1 to 4.3.4?

> Looks good but I think it would be worth while to also include the distinct identifier the flag was evaluated against Do you mean an identifier for the subject...