Toby Lawrence

Results 296 comments of Toby Lawrence

Interesting; nice find! This makes sense to me from reading your comment, but I want to spend a little time trying to check the official DDSketch libraries to make sure...

By the way, I haven't forgotten about this. Work has been busy, and I've been working with one of the DDSketch authors (I work at Datadog) on another internal Rust...

Yeah, this is what I ended up doing for now... but my complaint is really more about the ergonomics of it all. It _seems_ like `RateLimiter` ought to at least...

👍🏻 I ended up removing the rate limiting code to simplify some things during development, but I'll definitely swing back around and try things out with 0.6.4. I had also...

Definitely a typo, and we can definitely rectify that.... the power of not being at v1 yet! 😂

:wave: I saw and responded on the linked issue, but just to dive in a little here: > If you have something already using port 9000, metrics-exporter-prometheus crashes.. This is...

Without doing some sort of typestate builder to determine what gets returned/installed by the `build`/`install` methods... I don't having a configuration method like that could work. It feels like what...

> `with_local_recorder` requires the logic to be inside a closure, which isn't always feasible. Imagine for example running tests: cargo compiles a single binary per target, so if you have...

Yeah, using the local recorder with async code is indeed painful. I can see where something like `tracing::set_default` would be easier in tests where you're already running them in an...

I don't see a strong reason why it couldn't be made public. So long as the documentation indicates that it is not the preferred way to interact with the global...