Toby Lawrence

Results 296 comments of Toby Lawrence

Payload-level aggregation is definitely on the roadmap... just haven't gotten to it yet. I'll keep this issue open to track it. 👍🏻

Apologies, I had thought I had responded to this but clearly not... 😭 I'm not sure if you're still having an issue, but this looks like the classic `metrics` version...

I _think_ all we would potentially need to do is add a blanket impl in `metrics` for `impl Recorder for Arc where R: Recorder`? That would satisfy needing to provide...

My gut reaction is that I dislike it: it means that all metrics have the potential to disappear, and then reappear, out of thin air, with new labels. Potential issue...

This PR is unreasonably wide reaching. What is it exactly that you're trying to accomplish?

Overall, I think just blanket deriving `Debug` has the potential to rapidly clutter debug output, especially with some of the larger structs that are being updated here... but that's not...

Thanks again for going through all the small nits and revisions on this one. 👍🏻

Interesting. Thanks for the reproduction. Hopefully I can dig into this at some point soon.

As a small update, I did follow your instructions and was also able to reproduce this locally. Haven't started digging into _why_ it breaks, but good to know the reproduction...