Toby Lawrence

Results 217 comments of Toby Lawrence

@MOZGIII Whenever this is ready and you have a chance, it'd be good to have a 2-3 sentence summary of the changes, and some rough before/after numbers.

I've never gotten around to benchmarking it, but I wouldn't be against such a change since it does seem likely to provide a benefit in cases of short strings.

This is interesting, and could probably be done with a procedural macro that generates code that allows us to transparently generate a `&[Label]` derived from the struct fields... but you're...

> Perhaps the trait could be something like: > > ``` > trait AddLabels { > // self by value, can be implemented for both X (to allow moving of...

Thanks for reporting this. While I understand the current behavior of aggregated summaries is suboptimal for long-running processes, I'm not sure I have the time to craft an enhancement to...

There's been limited discussion a while back about it: https://github.com/metrics-rs/metrics/issues/19. It's not an item I'd personally spend time, but I'm definitely open to any PRs adding support for it. 👍🏻

Distinguishing between the "root" and "value" mode of extracting an archived type from a buffer would rank high on the list for me.

@JonnyWong16 Bumping this. Would you be willing to consider a PR for external database support?

I have a test branch -- `tobz/add-arm-support` -- that provides functioning ARM support. Biggest bummer is that for AArch64 (the architecture we target), the granularity of the underlying counter is...

This is addressed by #91. Still need to cut a release, though.