Toby Harradine comments

Repositories
Issues
Comments

Results 3 comments of


                                            Toby Harradine

Unable to format or exclude files which contain curly braces in the path

Possibly related to #552, #920

perf: improve analysis performance by 95% for `py_binary` and `py_test` rules

Hi @rickeylev :) I was also hoping I could avoid the additional C++ binary 😅 I did not think to replace the calls to `path.relativize` - I'll attempt your suggestions...

perf: improve analysis performance by 95% for `py_binary` and `py_test` rules

This is the profile after applying @rickeylev's suggestions - instead of using a C++ script, replacing `paths.relativize` and `paths.normalize` with simpler logic. Oddly `map_zip_runfiles` is still fairly significant (15% overall)...