tobolar

Results 125 comments of tobolar

> I solved this by changing row ` Modelica.Electrical.Analog.Basic.Capacitor C[dim_vector_lgc](C=Cl));` into ` Modelica.Electrical.Analog.Basic.Capacitor C[dim_vector_lgc](C=Cl, each v(fixed=true));` I chose this minimal change, to focus on the main objectives of this PR....

@tobolar what's your opinion? My personal opinion: 1. Shall be omitted due to regression issues. Optionally, the following could work for that particular example (being of the less implementation effort):...

> I've received today at 12.34 a mail stating that you've approved this pull request. I retrieved my approval since I'm convinced the library officers have to review.

> Can you, please let me know what is now mandatory for you to approve it? I have reviewed to my best regarding coding style, documentation, library structure. But not...

> LGTM - could have been clearer that this needs the other PR. Yes, PR of this branch on DagBruck:patch-2 would be a better option. Nonetheless, waiting for merging of...

@Harisankar-Allimangalath > from my understanding we should be adding the new content here Yes, this is how the release notes appear in a tool. What @beutlich means is there is...

I usually try to omit "Demo" in model names since each example is principally *demo*nstrating some model's feature, right? So to me it is generally a bad practice which should...

@AHaumer The reason for `c` final is #3707 (i.e. a clear model initialization). But this decision is not clear to a common user, so one could wonder why is `c`...

I suppose this is a question of the Modelica's modelling approach, not of a particular model, right?

> in the specific case one solution is to just remove the parenthesis (including its contents). IMO a good written text rarely needs parentheses.