ModelicaStandardLibrary icon indicating copy to clipboard operation
ModelicaStandardLibrary copied to clipboard

MSL v4.1.0-beta.1 feedback: Example name inconsistency

Open beutlich opened this issue 1 year ago • 4 comments

This is the topic split of #4304 where I wondered why some of the new example models are called _Demo_Something and others _Demonstrate_Something. One idea was to get rid of this Demo/Demonstrate prefix.

beutlich avatar Feb 21 '24 20:02 beutlich

Shift to next release sinve this is cosmetics

AHaumer avatar Feb 11 '25 15:02 AHaumer

No, renaming example models is not just cosmetics as it effects the regression testing. Not having the proper names now will certainly lead to unexpected regression evaluations later (missing result -> new result).

beutlich avatar Feb 11 '25 17:02 beutlich

missing result -> new result

If a model is renamed, the result files should just be renamed as well, not generated from scratch. This step needs to be taken regardless of if it's done now or for 4.2.0.

I agree with @AHaumer, we have to stop doing things for 4.1.0 to ever get it released.

maltelenz avatar Feb 12 '25 07:02 maltelenz

I usually try to omit "Demo" in model names since each example is principally demonstrating some model's feature, right? So to me it is generally a bad practice which should be omitted if possible in the future. (And yes, I myself sometimes indeed use "demo" for lack of better ideas.)

tobolar avatar Feb 12 '25 10:02 tobolar