tobim

Results 37 comments of tobim

If this is still needed, can you try if this patch fixes the tests: ```diff diff --git a/nix/tenzir/check.nix b/nix/tenzir/check.nix index b36f57b21b0..690a055f2ff 100644 --- a/nix/tenzir/check.nix +++ b/nix/tenzir/check.nix @@ -34,6 +34,7 @@...

Currently `tenzir-node` is just a symlink to `tenzir`. Maybe we can turn it into a little script that does the wrapping from above in case it is running inside of...

@dominiklohmann I believe we should also guard the read in the action: https://github.com/tenzir/tenzir/pull/4674/files#diff-a3ebba84face4449e084a934dd97e529546af867e7b4fe32dc73062e8febe5a1R387-R388. Can you verify and in case make the adjustment?

It is finished. The option only makes sense to use without `-DBUILD_SHARED_LIBS=ON`. Sorry for not making that clear.

The tested action does not work for our setup and there is currently no demand for this feature.

There is an important difference between the two in `nixpkgs` tho: `pkg-config` is patched to ignore `Requires.private` for `--cflags` without `--static`, whereas `libpkgconf` is not. I believe such a change...

The analysis seems right. To my understanding "standard" `pkg-config` just assumes that header declarations of a transitive dependency are automatically part of the direct dependencies API surface. This is essentially...