opentelemetry-cpp icon indicating copy to clipboard operation
opentelemetry-cpp copied to clipboard

[BUILD] Add a CMake option to disable shared libs

Open tobim opened this issue 1 year ago • 5 comments

This option is useful to support platforms that do not support dynamic libraries and dlopen.

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • [ ] CHANGELOG.md updated for non-trivial changes
  • [ ] Unit tests have been added
  • [ ] Changes in public API reviewed

tobim avatar Oct 12 '24 12:10 tobim

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: tobim (7d4291fa91dee4cf7de9f9a1763f803af36598fd, d85238c3b05c5ca6799df2ca95547fd33fc25bdf, 4fcdbf24537dc0e28c9cf12434ea585312c69fe3)
  • :white_check_mark: login: marcalff / name: Marc Alff (0875c095dd2a547686a6589b9476446229b3becf, 569b2da6071a3ab502c50b60f6afe7f8ec78f43a)

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
Latest commit 569b2da6071a3ab502c50b60f6afe7f8ec78f43a
Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/6716bd1fa07ea400084683b0

netlify[bot] avatar Oct 12 '24 12:10 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.91%. Comparing base (497eaf4) to head (569b2da). Report is 145 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3095      +/-   ##
==========================================
+ Coverage   87.12%   87.91%   +0.79%     
==========================================
  Files         200      195       -5     
  Lines        6109     6133      +24     
==========================================
+ Hits         5322     5391      +69     
+ Misses        787      742      -45     

see 98 files with indirect coverage changes

codecov[bot] avatar Oct 13 '24 15:10 codecov[bot]

Is this PR not finished yet? All add_library calls should consider this new option?

owent avatar Oct 14 '24 06:10 owent

It is finished. The option only makes sense to use without -DBUILD_SHARED_LIBS=ON. Sorry for not making that clear.

tobim avatar Oct 14 '24 06:10 tobim