tobil4sk

Results 366 comments of tobil4sk

#541 should mark these directories as third party libs as you suggested.

> Seems like a memory leak because the context is never free @ncannasse This is required for the entire lifetime of the program, which is why it could not be...

Although, the only issue with this is that now the variable must be set externally (either in config.h or every build system) rather then conveniently in the regexp file. Setting...

@Uzume Thanks for the insight! > match_context is a statically allocated pointer to a struct that is repeatedly allocated and initialized by pcre2_match_context_create Yes, I see the difference now (and...

Alternatively, I guess we could check whether the context object is null before allocating it, but I guess that might have some thread safety concerns attached to it.

> Agreed. I also think the best method is in the build system (over config.h configuration changes; in fact generation of the config.h could be handled by the build system...

@Uzume I think if we can handle it at compile time then that is the preferable solution. For now I have placed it in each build file as well as...

If we ever decide to link pcre2 dynamically this will have to be handled at run time again, maybe if that happens using a local static might be a fair...

There are multiple other settings for specifying static linking and disabling jit support that are defined in this config file and it wouldn't make sense to define the long list...

The stuff about the stack/heap changes sounds promising. If we can get rid of this setting then all the problems are solved. I doubt there were hashlink tests to make...