tobil4sk

@darmie Did you manage to solve this issue?

The code changed slightly when porting to pcre2. I can try to fix it because it wasn't too long ago when I ported it.

@Uzume The fix for `libs/ui/ui.c` was already applied in #218... If what you're suggesting isn't too complicated then you could open a PR to make a better fix, however otherwise...

The `libs/std/process.c` fix had also been done in #219, however not on the same line so git didn't pick it up, now signal.h is included twice in that file.

On this line the `CMAKE_OSX_ARCHITECTURES` string is being evaluated as an empty string... https://github.com/HaxeFoundation/neko/blob/b8ff4db70aa1376b4133e5936e6bb6ef68c6bd87/CMakeLists.txt#L60 Maybe on this line NATIVE_ARCH_ACTUAL doesn't exist for some reason?? https://github.com/HaxeFoundation/neko/blob/b8ff4db70aa1376b4133e5936e6bb6ef68c6bd87/CMakeLists.txt#L10

Yes, a long list of weird compiler errors, eg: ``` C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\um\oaidl.h(487,17): error C2059: syntax error: '/' [D:\a\1\s\libhl.vcxproj] C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\um\oaidl.h(502,17): warning C5103: pasting '/' and '/'...

So there were some issues with how the SDK was configured in CMake, which prevented it from the correct one being uses (it has to be set before the project()...

@ncannasse The only thing that's left now is that DirectX 12 is not supported on Windows 8.1, so compilation is failing now. WIth DirectX12 support being added, it may be...

Right now all the vcxproj files still have the windows 8.1 sdk, apart from the dx12 one: For example: https://github.com/HaxeFoundation/hashlink/blob/9cadbe5aacd32c22699a12b0a927627279a53506/hl.vcxproj#L33 https://github.com/HaxeFoundation/hashlink/blob/9cadbe5aacd32c22699a12b0a927627279a53506/libhl.vcxproj#L33 So the intention was to update to sdk 10...

@ncannasse Upgraded everything to win 10 sdk properly, and everything's building properly now so we're ready to merge. 👍