Tobias Melcher

@HannesWell : could you please take a look at this change? I had to introduce a new Runnable interface which passes the GC as argument. Is there already an existing...

Thanks a lot @HannesWell for all the feedback. Could you please take a look and review my latest change eb1dc57 ? As already mentioned, I had some troubles with the...

Understood. We would introduce warnings or errors for existing code which does call dispose, but not using try-with-resources. We want to find all the locations which do not call dispose...

> Thank you @tobiasmelcher for providing #1063. > > While reviewing your PR and looking at the applications of the new method I noticed two major drawbacks of the `GC#drawOn`...

the latest patch request contains implementations for windows, linux and mac. Windows:  Linux:  Mac:

Hi colleagues, I was able to reproduce the problem scenario in windows with the Java editor by enabling all code mining settings in the Java editor (preference page: Java->Editor->Code Minings)....

> @tobias-melcher Would you please try instead removing setBackground calls in > > https://github.com/eclipse-platform/eclipse.platform/blob/a791b17ec7febfe5631ea6e5a3df88e53ec0ca5b/debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/views/variables/VariablesView.java#L1165 > > ? IMO this flickering comes from background set once by the view and later...

I think I found it. ``` @Override Color defaultBackground () { return display.getWidgetColor (SWT.COLOR_LIST_BACKGROUND); } ``` Tree#defaultBackground returns a white color also when theme is set to dark. If no...

> IIRC we also configure the SWT colors according to the theme but they are set to late during startup. > > @azoitl tried to fix this a long time...

flickering appears because the tree background color is sometimes set to white in the dark mode because of following CSS: Tree[swt-lines-visible="true"] background-color: unset; org.eclipse.e4.ui.css.swt.helpers.CSSSWTColorHelper#setBackground is then called with color argument...