Tobias Berge

Results 24 comments of Tobias Berge

Hi @quisse You are right I think the error might be on our side here because some code was missing. But due to release time constrains we couldn't fully look...

Hi everyone, I reopened this issue for the moment since it seems to be a general thing. We are investigating what exactly caused the problem and will get back to...

Hi @quisse, sorry for the huge delay. We will process the PR again and resolve the conflicts.

Hi, I can confirm the same issue (pa11y version 7.0.0 and node v20.10.0). I am using not the CLI but a node script file. Happens for both runners axe and...

Hi @danyalaytekin, thank you for reaching out. 🙂 That sounds like a good workaround, I will try it out. 👍

Hi @lacknere, thank you for your contribution 🎉 and sorry for my late review. I know these are "just" blocks, but do you really need blocks on every single element?...

Hi @lacknere thank you. 👍 LGTM. And good catch with the wrong block naming `product_detail_`. 🚀

Hi @lacknere, you changes have been merged to trunk: https://github.com/shopware/shopware/commit/f5bc948b784cc53da487f9f62352d989ec0558cf and will also be backported to 6.5.x Thank you for your contribution. 🎉

Hi @averet-lea, sorry for my late reply. Thank you for providing a test app, thats much appreciated. 👍 We would actually recommend to use `PascalCase`/`UpperCamelCase` for app as well as...

Hi @averet-lea, thank you for testing and for your feedback. 👍 I would say if you already have an app with this naming and everything works for you at the...