tnbnicer
tnbnicer
``` this.downloadLink.addEventListener('mouseover', this.downloadAudio.bind(self)); this.downloadLink.addEventListener('contextmenu', this.downloadAudio.bind(self)); ``` Added to download link, so users don't download [source]*.html, for instance right-clicking to save. The `this.downloadLink` targets [source][audiofile], whether it's mp3 or some other...
In `multiple-instance.html` example, CSS classes have the wrong names. `.player-with-download` => `.player-download` `.player-with-accessibility` => `.player-accessible` See full diff in [compare view](https://github.com/greghub/green-audio-player/pull/55/files#diff-a39734a9d51627e49347290d9a61531e6e7417cbb64cb96178313148cac557a5).
@greghub Hi, I hope these commits of mine can be introduced into the code. I look forward to the next version of _green-audio-player_. Regards, Tom
### 1 ``` const uaDataIsMobile = window.navigator.userAgentData && window.navigator.userAgentData.mobile; this.isDevice = typeof uaDataIsMobile === 'boolean' ? uaDataIsMobile : (/ipad|iphone|ipod|android/i.test(window.navigator.userAgent.toLowerCase()) || (window.navigator.platform === 'MacIntel' && window.navigator.maxTouchPoints > 1)) && !window.MSStream; ```...
### On overcomeIosLimitations() function The [Safari canplay policy](https://github.com/video-dev/hls.js/issues/1686) – it is an iOS policy, deliberate – affecting audio and video, breaks the spinner. It spins endlessly. We shouldn't use `autoplay`,...
Would it be better to start from scratch? Some of the earlier proposed changes have been updated. The one to look for is `main.js`. Certainly it wouldn't be a problem...
Nice one. It works on Windows when you emulate Safari. `data-duration="3599"` No conflicts. Just checking.
As far as I know, Mp3s do not include the duration as metadata in a metatag. An accurate way to retrieve audio, and, I believe, also video duration involves opening...
Another skewing factor is the metatag size. Almost all audio formats have or support metatag info. Which is why file size alone gives a wrong duration estimate. In short, metatags...
I closed this issue, but I think it should stay open in case others experience similar issues. My solution was changing the line above to: `iconSprite: '[player dir]/[js and css...