Thomas Naake

Dear @lgatto many thanks for this initial screen. I have now fixed the issues in the [build report](https://bioconductor.org/spb_reports/MsQuality_buildreport_20221012073517.html) and addressed your comments. - `devtools`/`remotes`: I changed this accordingly in the...

Hi @jorainer if I understand correctly what you want to do then there are several metrics defined by the PSI working groups. Have a look e.g. at `QC:4000074`, `QC:4000075`, `QC:4000076`...

Was it not the initial idea to have an up-to date resource with relevant software packages for metabolomics packages? Is it possible to have a subsection where we list deprecated...

Dear @lgatto, many thanks again for the review! I have gone through your points and changed the package accordingly. Please see here for my responses: - **.github**: added to `.Rbuildignore`...

Thank you once more for your review!

Dear @sgibb thank you for inviting for the review (and sorry for late reply). Indeed I also think that `graphPeaks` is memory-consuming since we are dealing with huge adjacency matrices....

Hi @sgibb, many thanks for looking into this. Here are some comments: 1. in `joinPeaks` the function `validPeaksMatrix` is applied every time for each object `x` and `y` > validPeaksMatrix(x)...

Dear @jorainer sure. There is no need to change the `ppm` function. ppm is a random relative error on m/z values that is given by the accuracy of the mass...

I am voting for the 2nd solution. The error should be minimal. I agree that this should be properly documented.

Great, then let's go for a separate package. Should I create a repo in my repo and start with the implementation there? I guess I can start from next week...