한현빈

Results 36 comments of 한현빈

I think this issue is covered by #6908

I enabled experimental features and it captures those correctly

After further testing I have succeed in making minecraft to be aware of kotlin language provider ![image](https://user-images.githubusercontent.com/41675181/179453480-f09708d5-3c5e-47da-bfcb-a78f3761d019.png) [kff_testing_kit.zip](https://github.com/MinecraftForge/MinecraftForge/files/9129733/kff_testing_kit.zip) But it's still unable to access kotlin libs https://www.toptal.com/developers/hastebin/yusixinuwi.yaml `kotlinforforge-3.7.0-obf.jar` inside jarjar...

> After further testing I have succeed in making minecraft to be aware of kotlin language provider ![image](https://user-images.githubusercontent.com/41675181/179453480-f09708d5-3c5e-47da-bfcb-a78f3761d019.png) [kff_testing_kit.zip](https://github.com/MinecraftForge/MinecraftForge/files/9129733/kff_testing_kit.zip) > > But it's still unable to access kotlin libs https://www.toptal.com/developers/hastebin/yusixinuwi.yaml...

Yes, shadowing does work. Isn't kotlin jpms aware from 1.7.0? It contains module-info.java by default And jdk7 stdlib is for "stdlib for features added in jdk 7", not jdk7 compatibility...

So... what's the state of this PR?

I have updated this PR to latest 1.18 commit in my branch here: https://github.com/tmvkrpxl0/MinecraftForge/tree/updated-pr

It should also be targeted for 1.19.x, I just wanted to do it on 1.18.x first. I'll port this to 1.19.x soon

I have ported this PR to 1.19.x in #8932

Note that #8932 had a critical bug and changes HumanoidModel.java.patch from #8987 should be there too