Tom Thorogood

Results 23 comments of Tom Thorogood

https://github.com/julienschmidt/httprouter/blob/e1b9828bc9e5904baec057a154c09ca40fe7fae0/router.go#L340 uses `req.URL.Path` as the path to match against where `req.URL` is a [`url.URL`](https://golang.org/pkg/net/url/#URL). According to the documentation of `url.URL`: > Note that the Path field is stored in decoded...

Is this comparison algorithm used for anything other than RFC4034 or NSEC? It's rather generically named, so perhaps something like `RFC4034Compare` might be better if not. Though it's probably fine...

Could you split your example into a Dial followed by an ExchangeWithConn and time both separately?

Close should have very little overhead for UDP connections. It’s just a system call that changes kernel state. It doesn’t send anything like in TCP or TLS. I think that...

The [io.ReaderFrom](https://golang.org/pkg/io/#ReaderFrom) is implemented by [*net/http.response](https://golang.org/pkg/net/http/?m=all#response.ReadFrom) for HTTP 1.x connections. If the underlying connection is a [TCPConn](https://golang.org/pkg/net/#TCPConn) then it uses the optimised [sendfile](https://linux.die.net/man/2/sendfile) system call (see [(*TCPConn).readFrom](https://golang.org/pkg/net/?m=all#TCPConn.readFrom)) which, according to...

@alexandreStein Was this fixed with the merging of #36?

Just came across this issue and thought I’d add some context if anyone is interested. This was briefly discussed in a talk from a now ex-Facebook employee: https://youtu.be/7dPRFoKteIU. (Jump to...

I'm sympathetic to the performance concerns here, but this isn't quite the way to go about it. We'd need a pool on the Client struct itself. But considering there's been...

> holy moly this cleans stuff up. You know I thought it would, hence the PR, but even I was surprised just how much it improves things.

> Would be good to run the coredns testsuite with this version. Yep that's actually my hold up at the moment. I've been debugging and working through a few scattered...