Aman Karmani

Results 426 comments of Aman Karmani

> I will try to implemented the EXT_texture_norm16 extension (excluding GLES 3.1 requirements for now). This format extension seems to not be difficult to implement. Great, I will look forward...

Thank you for those pointers! > How do you intend to use 16 bits formats? Use them for OpenGL textures or IOS view layer/default framebuffer? I am using libmpv to...

I tried your suggestion of adding the missing formats to the json file, and it works just as expected! (It took me longer to setup python2, and depot_tools etc so...

> Or would it be better for me to expose a new extension like `EGL_EXT_gl_colorspace_bt2020_pq` and use that? I saw this in `generateExtensions`: https://github.com/kakashidinho/metalangle/blob/b3b8f451ba00f94a4c75089a63d316f74f31dc8d/src/libANGLE/renderer/metal/DisplayMtl.mm#L240 But still I don't see `EGL_KHR_gl_colorspace`...

> I need to figure out some way to take the `CVMetalTextureRef` and pass to MetalANGLE directly. Another idea would be to get an IOSurface from the CVPixelBuffer using [CVPixelBufferGetIOSurface](https://developer.apple.com/documentation/corevideo/1456690-cvpixelbuffergetiosurface?language=objc)....

I see also that you have a TODO for external image support: https://github.com/kakashidinho/metalangle/blob/aaa371f1b6acb22add0875377ebb5f6113cb652c/src/libANGLE/renderer/metal/DisplayMtl.mm#L572-L573 Is this something that could be used to sample from an external metal texture reference?

> talks about `eglCreateWindowSurface`, and I think that is not used with GLKit? So is it better to add more public APIs into MGLKView instead for controlling color space? It...

Thank you! I just started to figure out that `DisplayMtl::createPbufferFromClientBuffer` needed an implementation, but you are way ahead of me in 9fc9dddd83f047b6b314d498f12726893a1918d1 I think I understand all the pieces required...

FYI, today I built MetalANGLE in `Debug` configuration and tried with my app while debugging some PRs, and I discovered some ANGLE asserts are triggering. >ERR: setDefaultFramebuffer(8954): ! Assert failed...

I have been playing with `CVMetalTextureCacheCreateTextureFromImage` this week, and most YUV `CVPixelBuffer`s (such as `kCVPixelFormatType_420YpCbCr8BiPlanarFullRange`) can be mapped into `MTLPixelFormatR8Unorm` or similar (RG8, R16, RG16) formats depending on the plane....