Aman Karmani

>To be honest I don't quite get why removing || tableID.isUnknown() would fix your issue here 🤔 Can you explain it a little bit? The issue was that when an...

I ran the same sample through ffmpeg, and noticed: ``` [mpegts @ 0x7fd14b815000] PES packet size mismatch [mpegts @ 0x7fd14b815000] Packet corrupt (stream = 3, dts = 466149000). ``` Then...

> Ideally astits would detect and ignore this corruption. If we implemented the `CorruptedPacketHandler` described in https://github.com/asticode/go-astits/pull/22#issuecomment-817102091, these packets could be sent there instead of being silently ignored.

> Simple fix for #35 My first attempt was more complex: https://github.com/tmm1/go-astits/commit/a55f10a084899981331ca7924bf87305c71d4e08 That approach also works, but the same tests fail for the same reason.

The same behavior can be seen with `astits-probe data -d all -i `, where the SDT, PAT and PMT are not printed out until the end. ``` ... 2021/04/01 17:15:11...

So I think this bug is in `(*packetPool).add(p *Packet)`, here: https://github.com/asticode/go-astits/blob/077af8e17e39a8c822c46bd662cbf8ad6ea90a44/packet_pool.go#L61-L65 Basically we wait to flush out the PAT/PMT until the *next* packet shows up with a PayloadUnitStartIndicator set. Since...

Yes I will, I am trying to figure out what the best approach is first so any help would be appreciated. I think maybe we can make a special case...

>Furthermore that shouldn't be a problem when using the lib : if you don't want to miss out on PES packets, you can buffer them until you get the PAT...

Hmm, I thought before there was no CI but maybe travis CI was really backed up and didn't report back on my PRs when I was looking...

I don't have a preference and feel like all the CI services are interchangeable. TravisCI has announced that travis-ci.org will be shutting down. It's unclear when that is going to...