Mooneer Salem

Results 106 comments of Mooneer Salem

In that commit, `CMAKE_OSX_ARCHITECTURES` is ignored unless `BUILD_OSX_UNIVERSAL` is set to 1. The latest change I pushed will set `BUILD_OSX_UNIVERSAL` to 1 if you override `CMAKE_OSX_ARCHITECTURES`. Try again?

OK, I think it should take into account all current feedback now. Once I get a confirmation that it builds, I'll merge.

Just tried to sync with the Arduino again and it appears that the time is more accurate now: Your time is exact! The difference from Time.is was -0.014 seconds (±0.035...

> @lukasostendorf - thanks, I'm currently traveling but will review this and the proposed fix in a few weeks. > > @tmiw - do you have any comments? Seems fine...

I created https://github.com/drowe67/codec2/pull/45 with what I was able to get to tonight. There's still something like 14 ctest failures with libasan on, but I suspect at least a couple are...

> @tmiw - did any of the issues detected by AddressSanitizer cause any actual, real world issues, when running say freedv-gui? The changes in #45 are minor tweaks mainly in...

@hobbes1069, @drowe67, I'm thinking single library would be best from a distribution perspective. That said, how far back are we expecting to support hardware-wise? I know for the macOS version...

> I know on Fedora x86_64 assumes SSE1 is available and is no longer distributing a 32bit install (but 32bit binaries and libraries are still available if needed). Of course...

The upstream has diverged enough that it would be a significant effort to get back in sync. Plus, I'm not sure the existing 2020/2020B modes would be able to work...

Thanks for this feedback. Some work was started on this earlier, see https://github.com/drowe67/freedv-gui/pull/600. It's currently on hold for a few reasons: 1. The initial feedback was negative. While the sample...