Tzvetan Mikov
Tzvetan Mikov
> Question; does every `ArrayBuffer` have a `jsi::MutableBuffer`, even those created from JS? > Or does this only apply to `ArrayBuffers` that were created with the `jsi::MutableBuffer` API? Technically, today...
Hi, unfortunately it seems like we won't be able to merge this PR. I apologize, Meta, for better or worse, has decided that it cannot dedicate the resources to maintain...
@thomasttvo hi, `Error.stack` is not part of the ECMAScript spec, so any behavior is valid. However, the example you have shared doesn't seem to work in any engine. I just...
@thomasttvo Do you have an explanation of what the point is of putting an Error object in the prototype? What does it accomplish? More importantly, is there a formal specification...
@thomasttvo this is most definitely not how inheritance was implemented pre-ES6. At the very least it should call the parent constructor.
We understand this is a real problem users of Hermes are having and we want to help. But we need to understand what the solution is.
@thomasttvo yes, I think I am beginning to get the picture. One way or another we will make sure the `stack` getter doesn't throw.
This is the fix, landing in Static Hermes. The getter returns the stack from the prototype. https://github.com/facebook/hermes/pull/1497
> @tmikov looks like the fix was cancelled? It wasn't cancelled. As can be seen clearly above, it was committed in https://github.com/facebook/hermes/pull/1497
@wobsoriano yeah, I am not sure why it doesn't say "Merged", when it clearly was: