Tzvetan Mikov

Results 274 comments of Tzvetan Mikov

Cool! I think we will do that as the first step. Meanwhile we will work on a "proper" native implementation. Which one gets into the next release is a matter...

@noencke planning to add a polyfill to Hermes as soon as I have some time.

@mrousavy this is quite surprising to me. Where did it come from? How is it implemented? A polyfill like the one we discussed is certainly possible, but it is not...

@spendres Hermes has had a usable weakref for years, however it needs to be enabled by RN. I believe it is enabled in new-architecture apps.

@wcandillon you are right - FinalizationRegistry is a clean solution to this, albeit a little heavyweight. For now I recommend the approach I described here: https://github.com/facebook/hermes/issues/1780#issuecomment-3289847609: an explicit queue drained...

We actually don't support compiling static_h with MSVC at the moment. But PRs with fixes are always welcome.

Try setting HERMES_ALLOW_BOOST_CONTEXT to 0

That is expected, shermes using Unix functions to load the compiled .so for the "-exec" option. That can work on Windows, but would require different APIs. You can comment that...

@mikeduminy it might also be very useful if you could upload somewhere the final JS bundle of the repro app (before it is compiled by Hermes). Then we can compile...