Travis Cline
Travis Cline
Definitely open to any design input and ordering in terms of breaking #8564 down This is a model-assisted cut at making that large PR more manageable https://github.com/tmc/osquery/blob/endpointsecurity-expansion-stacked-diff-planning/osquery/events/darwin/ES_DIFF_PLAN.md I'm open to...
This is a model-assisted breakdown of circumstances to cover and areas to expand coverage. **Legend:** * ✅ : Feature set directly enables or significantly simplifies detection/analysis for this use case...
I haven't had time to attend a meeting to discuss this change but still believe it improves the quality of this library for Go developer/systems administrators.
Awesome! thanks for contributing this -- can you rebase the history here and get the lint passing?
> Hi there is a bit more active fork at https://github.com/ergochat/readline, is it reproducible with that? https://github.com/ergochat/readline/blob/master/runebuf.go#L498
Thank you!
IMO they shouldn't be -- the agents package has this and other design issues -- I'm tempted to tuck it away and come up with a fresh api -- feel...
@jubeless could you address the PR feedback above?
Can you be a bit more specific in your proposed solution?
I'd define that type more generically: ```go type AttributeProvider interface { Attributes() []attribute.KeyValue } ``` That said I think a more direct manner of allowing Errors to define the value...