Results 51 comments of Tyler

@iguessthislldo, I believe the parsing is done, are you able to take a look at this.

> I'm not sure if including the MPC submodule is intentional or not. If it is, I think it would better for a separate PR. That was not intentional, will...

> I'll make the change. And I'll be honest I'm doing this more for the fun and experience of it rather than for a particular purpose, so I'll do whatever...

So I'm pretty sure I got the code generation for maps working, it's just an std::map typedef. I'm not sure exactly where to `#include ` right now it just includes...

I think this is done and ready for proper review, I've already started messing with this branch in OpenDDS

It's been quite a while since I opened this and I know it's a fairly massive PR, but I did just want to get some clarity on what's needed for...

That's fine, take your guys' time, I just wanted to make sure it wasn't blocked on me. I appreciate everything done so far.

> ``` > 2022-10-05T07:29:22.2971107Z /home/runner/work/ACE_TAO/ACE_TAO/TAO/TAO_IDL/be/be_visitor_map/cdr_op_cs.cpp:26:1: warning: unused parameter ‘node’ [-Wunused-parameter] > 2022-10-05T07:29:22.2971801Z be_visitor_map_cdr_op_cs::visit_map (be_map *node) > 2022-10-05T07:29:22.2972112Z ^ > ``` > > ``` > 2022-10-05T07:37:26.4155029Z /home/runner/work/ACE_TAO/ACE_TAO/TAO/orbsvcs/IFR_Service/ifr_adding_visitor.cpp:2305:1: warning: unused parameter ‘node’...

Also this warning ``` ISO C++ forbids converting a string constant to ‘std::map::key_type’ {aka ‘char*’} [-Wwrite-strings] ``` If I remember correctly I'm using the wrong string type, I had trouble...

Would this test be what you're talking about `tests/DCPS/LargeSample` or are you referring to something else? Are you talking about a test/example for how to extract the data after receiving?