Tomáš Matoušek

Results 121 comments of Tomáš Matoušek

@jbevain Please take a look and let me know what you think.

@MI3Guy Microsoft.DiaSymReader.dll is open source (https://github.com/dotnet/symreader). Microsoft.DiaSymReader.Native.*.dll are not open source. The current implementation uses the one installed on your Windows machine, which is also not open source. I'm open...

The nuget package is currently pre-release and thus on myget: https://dotnet.myget.org/feed/symreader/package/nuget/Microsoft.DiaSymReader. It will be published to nuget once it's release quality. I hear you. I'm just saying Cecil has a...

I guess is not that "hard" since you're not getting it if you're not on Windows.

Re license: I think @MI3Guy is concerned about the Cecil package having a dependency on packages with MS-EULA license. We are working on sorting that out (changing the license of...

On Windows Cecil is actually not self-contained. It has an external dependency on diasymreader.dll that's shipping with Windows thru COM instantiation. That component is buggy. We have been fixing these...

Re the reader: We can replace the reader as well. Microsoft.DiaSymReader provides the APIs needed to read all of the info.

> Taking a dependency on Microsoft.DiaSymReader.Native means that if someone wants to use Cecil to read native PDBs they need to ship that DLL as well. That's correct. I wouldn't...

@jbevain Looking into this again. If we have two providers how do we decide which one to load in SymbolProvider.GetReaderProvider? Do we try load the DiaSymReader one first and if...