Liu Yongliang

Results 18 comments of Liu Yongliang

> 你有做实验 试过 把代码删除之后的结果吗 抱歉没注意到它和 line 166的代码有所差异。可以的话我增加了一个注释,也许会更清晰:) (如果不需要的话可以close这个PR 🙏 )

Hello, I think making deployment of the dashboard independent of the outer site that is currently utilizing the GitHub Pages may indeed be troublesome due to interference (being overridden by...

> Thanks for looking into this @tlylt > > I'm not sure if it will work for the use case of deploying code dashboards as part of CS2103 website. This...

> > @NullVoxPopuli I think I did what you mentioned in your comment. You can check my workflow here: > > https://github.com/calitb/VueJS-Sample/blob/master/.github/workflows/deploy_staging.yml > > @calitb Thank you for this. This...

Hi, may I check if there are any updates on this PR? I faced a similar issue lately, the use case is as such: - I will use the all-contributors...

> > I'm failing to understand whats wrong with the CI check though > > > error [email protected]: The engine "node" is incompatible with this module. Expected version "^12.17.0 ||...

> Now there is an unrelated test failing, I suspect this is a side effect of upgrading circleci node version, I'll look into it > > ```jest-snap > [test] FAIL...

Hi @tenshiAMD, wonder if you know whether this change will propagate to the all-contributor bot immediately or will need to wait for the https://github.com/all-contributors/app side to update?

> > Hi @tenshiAMD, wonder if you know whether this change will propagate to the all-contributor bot immediately or will need to wait for the [all-contributors/app](https://github.com/all-contributors/app) side to update? >...

> @tlylt can you check again now? Please let us know. Thanks! 🎉 Tested and works well! Thank you for the follow-up 💯