Talley Lambert
Talley Lambert
since none of this falls under the original proposal of editable keybinding objects... can we start a new issue for this?
I suspect the concert is strong refs inside the partial, is that true @Czaki? If so, it implies that the "proper" solution here would need to consider or reimplement all...
> Or is there an obvious use case for short living actions? Nope I'm happy to consider these as long lived objects and just use a simple dict
... and if there is never an intention of passing more complex arguments, can you remind me again why `Action(id="cmd_id2", title="title2", callback=cb, kwargs={"a": 1})` is so much better than `Action(id="cmd_id2",...
> Connecting partial to signal is a bad pattern that may lead to multiple problems (especially when writing tests). not when all of your arguments are simple. We are *far*...
> You know this, I know this,and for example jni makes PR with lambdas connected to signals in examples (https://github.com/napari/napari/pull/6881. But that's only an issue because it's wrapping a complex...
perhaps one way we could go about this is for you to make a subclass if Action in `napari` as an exercise in implementing whatever changes you'd like to see....
ok, see #194 which passes control of Action registration to the CommandRegistry. Note that the command registry has always been extendable: you need to pass your own custom subclass when...
#194 is released in v0.2.7. So if you'd like to experiment more on the napari side, it should now be easier
oh! It looks like that issue in disconnection is already fixed by https://github.com/pyapp-kit/psygnal/pull/236 (which hasn't been released yet)