Talley Lambert

Results 870 comments of Talley Lambert

Aha! Yes indeed. `__new__` is the real constructor (inside of which an exception would prevent object creation). `__init__` is there as a way to initialize a newly constructed object. Tricky!...

I just realized that this only happens when `run_stale_examples` is set to True

> is this acknowledgement in licenses good for you or could you suggest something better? 👍 just fine thanks :)

this is something I've discussed with @DragaDoncila a few times. can't remember where those conversations went. I'm not sure I would agree that these should be editable. Instead, I was...

So, what's "immutable" (and what I would argue should stay immutable) is the fact that napari, or some plugin, or some user, says "I associate this keybinding with this action"....

just for clarity... what I'm referring to is the "source" column when you go to edit your keybindings in vscode:

thanks for the link @DragaDoncila,

actually... following that issue, I can see that @lucyleeow already responded to your concert about this @Czaki in https://github.com/napari/napari/issues/6516#issuecomment-1886127528 ... but you didn't clarify your concern there

> Current implementation resolves shotcuts in register order yes, because, as mentioned above, app-model only has a single keybinding registry. And also yes, as described by @lucyleeow and @DragaDoncila in...

i agree. one reg, with added `source`. another thing that i always intended is for `get_keybinding` to take in a context. For example, using the image from above again: ![image](https://github.com/pyapp-kit/app-model/assets/1609449/86aecfc7-609a-4bae-bcfd-bef28d316985)...