tksharpless

This is a complex work in progress, not expected to be production ready for some time. The purpose of this pull request is to let facebook devs examine the proposed...

It appears that zlib is not installed on the test build system. This cannot be due to the code changes in the branch under test.

Glad that the Linux build is working. I still have to add ispc and test to the Windows build, then will push again. I don't envision any further changes that...

Question about Dep_unit_test. In CMakelists.txt one of the target link libraries is specified as 'gtest', but there is no find_package() for gtest. How does this library reference get resolved on...

I still don't understand what is going wrong here. The facts are: 1) your original cmakelists.txt mentions gtest only once, as a link library name. The resulting project specifies that...

When I build with the hand-corrected vcxproject, -- gtest.dll gets copied to the project bin directory along with the other rq'd dlls -- DepUnitTest runs all 29 tests successfully (log...

Albert, can you supply a set of binary image/strip files for testing the GlViewer? On Mon, Oct 14, 2019 at 1:50 PM Facebook Community Bot < [email protected]> wrote: > @tksharpless...

That is an awfully big file, but I will try it. On Wed, Oct 16, 2019 at 9:17 PM Albert Parra Pozo wrote: > @tksharpless we somehow forgot to add...

Hi Albert I have paid no attention to FB-DEP in the past couple of months; devoting all efforts to my own depth mapping pipeline. Did I promise to test the...

Hey I f*ing well did provide a nice long description with steps to reproduce, and GitHub ate them. e-mail me if you want that. Meanwhile, just put find_package(zlib REQIRED) at...