tkennes

Results 10 comments of tkennes

Sure, let me pick it up! :)

Hola @ericksod! I've picked up the issue, but I'm a bit unsure how to properly test it. I'm a bit rusty with Yarn and Typescript. I do have an Azure...

Great initiative! But perhaps the scope should be refined a bit better. The major cloud providers already offer this: - AWS: https://docs.aws.amazon.com/eks/latest/userguide/autoscaling.html - Azure: https://learn.microsoft.com/en-us/azure/aks/cluster-autoscaler - GCP: https://cloud.google.com/kubernetes-engine/docs/concepts/cluster-autoscaler I've worked...

Running a dry-run for the sa gives me this: ``` # Source: nlaks-keda/charts/keda/templates/01-serviceaccount.yaml apiVersion: v1 kind: ServiceAccount metadata: labels: app.kubernetes.io/name: keda-operator azure.workload.identity/use: "true" helm.sh/chart: keda-2.10.2 app.kubernetes.io/component: operator app.kubernetes.io/managed-by: Helm app.kubernetes.io/instance:...

Exactly, that's why I proposed the nindent :). Sure. But I'll provide a couple more fixes. The reason I have this weird annotation is because of issues on my servicemonitors,...

@tomkerkhove : I don't really understand the lack of flexible when it comes to setting annotations for specific resources, could you explain? Also, would it not make more sense to...

@tomkerkhove , in that case, it depends a bit on the cluster whether annotations are heavily used for individual resources. As a rule of thumb, you would use labels for...

> Added some breaking changes, but would you mind also fixing DCO? @tomkerkhove , this should be resolved by now right?

> This is OK for me, can you pull in the changes from main & document the new options please? I don't think you need documentation here, since you are...

> We should document all options, even if they are well-known ones because people who are new to the cloud-native space would not know about them unfortunately. > > Given...