Tomáš Karabela

Results 51 comments of Tomáš Karabela

I was thinking about something like this: ```py import pysubs2 import os.path def snap_to_frames(subs: pysubs2.SSAFile, format_: str, ts: pysubs2.Timestamps): for e in subs: old_start_ms = e.start old_end_ms = e.end start_frames...

Thanks, I see. If you have any examples, that would be helpful :) Feel free to link them here or send me an e-mail to tkarabela at seznam dot cz....

> ### Remaining problem > > I would need to have the `TimeType` in the method `make_time` https://github.com/moi15moi/pysubs2/blob/f9ea3c5863e795d37ce6e93f9fc2db9e8dab94b8/pysubs2/time.py#L44 I agree, we need an additional parameter with default value `TimeType.START` (so...

> This will cause the same problem has the current shifting since the `e.start/end` can be anything. Even if `e.start/end` is snapped to the frame, **it does not always works**....

Ah, you're right, ffmpeg messes up the .mp4 output somehow. With .mkv it's good. I've tried with the first 23.976 video example: ```py import subprocess import pysubs2 subs = pysubs2.load("test_video.srt")...

Hi @moi15moi , I'm ill at the moment, I will continue when I'm able to. Your code looks good.

I agree :) The WebVTT support is very basic at the moment. What is more relevant for your use-case: converting existing .ass to .vtt, or getting .ass formatting out of...

Hi @milahu, can you tell me what you wish the library did instead of raising `UnknownFPSError` in this case? If you want to assume a "default fps", you can do...

The library internally works with milliseconds, not frames - specifying framerate is not optional when reading MicroDVD. - One can specify the framerate directly as the `fps` parameter - (in...

Ah, maybe I'm beginning to understand, let's go back to your initial examples. **Example 1** Would you like to see this throw `UnknownFPSError` as well? ```python import pysubs2 text =...