Thomas Jungblut

Results 129 comments of Thomas Jungblut

Not sure this is very easy to do with GRPC and I think we're likely not going to rip out GRPC to enable this for peer traffic. Did you try...

Actually, sorry for the misinformation, after browsing the rafthttp code it's just plain HTTP(s). I was confused because we always use protobuf to write locally and send over the wire...

Thanks @cenkalti /lgtm (non-binding)

> The existing manually promotion API still works, but should be deprecated, and to be removed in next next release (e.g. 3.7). @hasbro17 fyi

> Is OpenShift still using 3.4? cc @tjungblu to double confirm Not with any currently supported version. Just to also give you some more data points here, to stay supported...

Can you explain what the semantics and use cases for those new fields are? I honestly also don't think I understood the proposal fully, is this about moving this code...

> Please give me more context on why you want to introduce this failpoint. I want to make sure that we not only code it, but also address the overall...

Sure, do you guys want to keep the failpoint? I can remove the remainder.

rebased, updated and removed the remainder of unrelated changes

> Etcd logs are available the same way as e2e logs. By passing EXPECT_DEBUG=true flag to the test run. If you feel like browsing the logs is convenient enough already...