etcd icon indicating copy to clipboard operation
etcd copied to clipboard

Retain process logs on robustness tests

Open tjungblu opened this issue 1 year ago • 8 comments

Adding a new flag to retain e2e etcd process logs after stop and saving next to the visualized model.

Spun out of #16018 where I used it for easier local debugging on model violations.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

tjungblu avatar Jun 14 '23 08:06 tjungblu

Etcd logs are available the same way as e2e logs. By passing EXPECT_DEBUG=true flag to the test run.

serathius avatar Jun 14 '23 09:06 serathius

Etcd logs are available the same way as e2e logs. By passing EXPECT_DEBUG=true flag to the test run.

If you feel like browsing the logs is convenient enough already I'm happy to close. For me it makes more sense to have the member debug logs next to the history.html in the artifacts zip.

tjungblu avatar Jun 14 '23 10:06 tjungblu

If you feel like browsing the logs is convenient enough already I'm happy to close. For me it makes more sense to have the member debug logs next to the history.html in the artifacts zip.

It's not https://github.com/etcd-io/etcd/issues/15079

serathius avatar Jun 14 '23 10:06 serathius

FYI main challenge here is to merge logs from between server restarts.

serathius avatar Jun 14 '23 11:06 serathius

@serathius created an aggregation of LogExpects to merge the logs. Let me know if the implemented behavior works for you, too (mostly on the expect side of things).

tjungblu avatar Jun 14 '23 14:06 tjungblu

Also, please remove environment EXPECT_DEBUG from the Robustness tests github workflow.

serathius avatar Jun 15 '23 15:06 serathius

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 17 '23 01:09 stale[bot]

@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-verify b5cdfc099fe6d05e02789f642f43f7ea417e1186 link true /test pull-etcd-verify
pull-etcd-unit-test-amd64 b5cdfc099fe6d05e02789f642f43f7ea417e1186 link true /test pull-etcd-unit-test-amd64
pull-etcd-unit-test-arm64 b5cdfc099fe6d05e02789f642f43f7ea417e1186 link true /test pull-etcd-unit-test-arm64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot avatar Aug 05 '24 22:08 k8s-ci-robot