Timo Heister

Results 351 comments of Timo Heister

Thank you. I guess @naliboff is busy with other stuff. 😉

In progress/ future work will likely be outdated quickly, so I agree with putting that into the issue tracker / board instead.

We already have .clang-tidy files in the repo that specify the check. We also have aspect/contrib/utilities/run_clang_tidy.sh. What advantage does your approach have?

> you can set it to fix some stuff automatically I should add that to the script. I used to just change that locally... > Timo do you plan to...

Thank you for reporting this issue. This is indeed not how it should look like. We might have an underresolved mesh for the viscosity chosen here. You can try that...

> I just want to add here that in case you make a new `examples/` directory, it would be worth moving the files from `cookbooks/future/` there as well Yes, I...

I am not sure if this makes a difference in test output or if anything else breaks because of it, but this ordering seems correct to me.

@gassmoeller why does "linux / tests" pass? This seems wrong.

It seems that the prescribed dilation test now fails. I have to think about this some more...