aspect
aspect copied to clipboard
geodynamics
Add clang-tidy option to CMakeLists.txt.
This pull request would add an option to cmake to check the code with clang tidy, and even has the option to automatically fix a lot of the issues it finds which you can turn on and of with this script. Both options are off by default. I don't know if that is something we would want in ASPECT, but I found it to be useful for the world builder I would like to at least offer it for consideration.
If we decide we would want something like this in aspect, we can take a look at the precise flags which would be relevant for aspect. These are just the flags I use for the world builder, but I don't think they would all fully fit with the desired style of aspect.
We already have .clang-tidy files in the repo that specify the check. We also have aspect/contrib/utilities/run_clang_tidy.sh. What advantage does your approach have?
Is our code base even clean with regard to these flags at the moment? If not, maybe we can start by creating patches to this end.
Other than that, we could also make that a CI step rather than hooking it into the cmake configuration?
There is still #3898, Timo do you plan to revive that at some point? I can certainly integrate clang/clang-tidy into the new tester in #4103. I am also voting for a CI step instead of (or in addition to) the cmake option.
Ah, sorry. I totally forgot, and did not check, that there was already a clang tidy. Sorry about that. Integrating it into the ci would be nice.
The advantage of the cmake option is that you can set it to fix some stuff automatically (I didn't see that option in the script), and you can set it to automacally check every time you compile. The advantage of he script is that it is run outside the compilation step. I don't have preference for the way it is done, and I am happy to close this if we decide to go for the script option.
you can set it to fix some stuff automatically
I should add that to the script. I used to just change that locally...
Timo do you plan to revive that at some point?
I can revive it, but we can talk about what the better option is...