Tiago Quelhas

Results 21 issues of Tiago Quelhas

### Description of the bug: Skyframe doesn't track the existence of empty directories inside a tree artifact. As a result, if a tree artifact with an empty directory is produced...

type: bug
team-Remote-Exec

This makes the integer division check more accurate when these expressions are involved.

A ctx.actions.symlink whose output is a declare_file or declare_directory (as opposed to a declare_symlink) has "copy" semantics, i.e., the output artifact is indistinguishable from the referent except for its name;...

team-Remote-Exec
awaiting-user-response

When attempting to remotely execute an action that produces a dangling symlink, the remote executor throws an exception here: https://cs.opensource.google/bazel/bazel/+/master:src/main/java/com/google/devtools/build/lib/remote/UploadManifest.java;l=194;drc=93029d8f1f01be440d8e06cce9585ad912f9169b This must be fixed before integration tests for dangling symlinks...

P2
release blocker
team-Remote-Exec

When a remote action produces an undeclared symlink (i.e., a ctx.actions.declare_symlink) pointing to an absolute path, an exception is thrown here: https://cs.opensource.google/bazel/bazel/+/master:src/main/java/com/google/devtools/build/lib/remote/RemoteExecutionService.java;l=745;drc=bce7db055dd702e8a101f975f8585e0dfeb18a67 We will also have to fix #16289 before...

P1
release blocker
team-Remote-Exec

The tests don't currently pass due to #16290 and #16289. Making them pass might be considered a blocker for #10298 (declaring unresolved symlinks stable).

Similar in spirit to https://github.com/bazelbuild/bazel/commit/bb8031989397633326520720013f23eff91d8a42. DigestUtil wraps DigestUtils, trading in Digests instead of byte arrays. There are probably other callsites that would benefit from the optimization, but I'm focused on...

team-Remote-Exec
awaiting-review

The input Merkle tree computation often shows up in profiles holding up the critical path. The `--experimental_remote_merkle_tree_cache` optimization, which was introduced to alleviate this problem, doesn't work reliably (for reasons...

type: bug
untriaged
team-Remote-Exec

team-Performance
awaiting-PR-merge

Originally reported by @tyler-french in https://github.com/bazelbuild/bazel/issues/20886 (but seems to be a separate issue). Minimal repro (Linux): .bazelversion ``` 7.0.2 ``` .bazelrc ``` build --noenable_bzlmod ``` repo.bzl ``` def _impl(rctx): rctx.file("file.txt",...

type: bug
P1
team-Local-Exec