Tom Jenkinson

Results 110 comments of Tom Jenkinson

hmm interesting. Feel free to open a pr changing the class name to something more specific

This is the same issue that I mention in this PR: https://github.com/clappr/clappr/pull/1115 So if the above PR is merged and 'Clappr' changed to 'clappr' in https://github.com/clappr/clappr-level-selector-plugin/blob/master/webpack.config.js it should work. You...

This plugin (and others) should have its externals webpack config like this: https://github.com/clappr/clappr/issues/1145#issuecomment-246009624 We should make a note of this somewhere in the readme

Also clappr-zepto should be accessed on clappr itself so doesn't need to be in the package.json or webpack external

Yep named capturing groups are not supported right now. Index ones are though.

Fine with me. I already highlighted some of the differences but if there are more important ones feel free to add them :)

Ah I see. I think the main difference is the one I [mentioned on the readme](https://github.com/tjenkinson/url-toolkit#differences-to-js-url). I doubt much else has changed, but I haven't spent loads of time checking...

Just opened https://github.com/facebook/react/issues/29058 which seems very similar

This is blocked until `eslint-typescript` v7 is released which supports eslint 9 https://typescript-eslint.io/blog/announcing-typescript-eslint-v7