Tom Jenkinson

Results 110 comments of Tom Jenkinson

Sorry I'm really busy at the moment. It sounds like nice feature and possible at the moment if you parse the file yourself to generate the config from. This looks...

I could do with these new features as well :)

I'm working on a fork for now so I have can point to it from a package.json file. Will switch it to point here when this is merged :)

If there's the end list tag it still can be an EVENT stream, which isn't VOD. > On 14 Aug 2016, at 09:54, Kasher [email protected] wrote: > > You can...

It should be classed as VOD if the X-PLAYLIST-TYPE header is VOD and I think that's the only case. If the tag isn't there then it should be treated as...

I just checked an [example from twitch](http://vod.edgecast.hls.ttvnw.net/v1/AUTH_system/vods_e1c8/quin69_22872637984_501988667/medium/index-dvr.m3u8) ``` #EXTM3U #EXT-X-VERSION:3 #EXT-X-TARGETDURATION:2 #ID3-EQUIV-TDTG:2016-08-17T09:28:40 #EXT-X-PLAYLIST-TYPE:EVENT #EXT-X-TWITCH-ELAPSED-SECS:0.0 #EXT-X-TWITCH-TOTAL-SECS:14947.112 #EXTINF:2.000, index-0000000029-ogjS.ts?start_offset=0&end_offset=116371 #EXTINF:2.000, index-0000000029-ogjS.ts?start_offset=116372&end_offset=283503 #EXTINF:2.000, index-0000000029-ogjS.ts?start_offset=283504&end_offset=485039 #EXTINF:2.000, index-0000000029-ogjS.ts?start_offset=485040&end_offset=677175 #EXTINF:2.000, index-0000000029-ogjS.ts?start_offset=677176&end_offset=864047 #EXTINF:2.000, ... #EXTINF:2.000, index-0000007469-kXHB.ts?start_offset=5509340&end_offset=5713695 #EXTINF:2.000,...

I might be wrong but I think there should be a new `endList` property [here](https://github.com/tedconf/node-m3u8/blob/master/m3u/Item.js#L5) Then [here](https://github.com/tedconf/node-m3u8/blob/master/m3u/PlaylistItem.js#L37): ``` javascript if (this.get('endList')) { output.push('#EXT-X-ENDLIST'); } ``` and [here](https://github.com/tedconf/node-m3u8/blob/master/parser.js#L44) should be: ```...

Blocked on https://github.com/chaijs/sinon-chai/issues/160

This was the exact same issue I had. We ended up just checking if the error has a `code` property that matched some of the AWS error codes but it’s...

As things like this might have a performance hit would it be possible to allow the user to enable and disable these features in the config? Maybe they could then...