Tom Cafferkey

Results 28 comments of Tom Cafferkey

Thanks @Aljullu, great work on this. I will make sure I get around to reviewing this today/tomorrow!

@Aljullu It looks like with this PR we have just moved the individual template rendering logic into its own controller. Can you confirm that's right? Whereas a bunch of the...

@gigitux @Aljullu can you remind me what logic [like this](https://github.com/woocommerce/woocommerce/blob/trunk/plugins/woocommerce/src/Blocks/BlockTemplatesController.php#L172-L264) is for again? What would make a template eligible or ineligible for a fallback? My thinking was (and maybe I'm...

Thank you @thealexandrelara and @gigitux. Looking forward to this improvement!

@thealexandrelara wondering how you got on with https://github.com/woocommerce/woocommerce/pull/47636/ was it the same issue as the one described in this issue?

Great investigation and summary @samueljseay. Considering this is labelled as a high priority issue I'm going to ping a few folks to see if we can come up with some...

@jlamap I've opened a PR here https://github.com/woocommerce/woocommerce/pull/48137 if you get the chance and would be interested in reviewing the change that would be hugely appreciated. Thank you for your help...

@gziolo since @ockham is AFK I was wondering how I should proceed with this?