Tom Cafferkey
Tom Cafferkey
I might be wrong but I think you need to line separate the linked issues to ensure this PR closes them automatically when this is merged. ``` Fixes https://github.com/woocommerce/woocommerce-blocks/issues/6838 Fixes...
@dinhtungdu I've merged https://github.com/woocommerce/woocommerce-blocks/pull/7101 and this PR is looking like it's shaping up to be a good approach after some testing. One thing I've noticed which I am going to...
>One thing I've noticed which I am going to try and work on is setting the block attributes once they've been upgraded. For example, upgrading the Attribute block asks you...
@Aljullu I've upgraded this approach (https://github.com/woocommerce/woocommerce-blocks/pull/6978/commits/0d178861fb82672cb30469877f86702a6fc33f51) to display the notice the same way as Gutenberg did in your screenshot.  We could probably do with...
I have done some user testing on this including with the classic Storefront theme as widgets and it is looking good. I am yet to review the code though as...
The code LGTM, I've asked some questions which are non-blockers but before approving can we check out this failing test please? `Filter Products by Stock Block › attributes › product...
@dinhtungdu I cannot approve my own PR but this PR now LGTM! 😄 It tests well, and the code LGTM. Im not sure whether you would like to wait for...
Merging this, failing tests are unrelated to this PR as they are Mini Cart related.
Just raising here, my only concern with this approach is that it convolutes the code for this block. So I keep asking myself: * How long would this logic have...
@vivialice it's still a bit of a proof of concept so text and behaviours can be changed, we were just testing the approach from a technical standpoint. >Also, this is...