Thomas Baker comments

Results 7 comments of


                                            Thomas Baker

RefResolver.resolve_fragment() breaks nested relative references

@Julian @agoose77 @bartfeenstra Do you all have any fresh thoughts on this? We are using this with our generated schema that has definitions with`$ref`s to other definitions that is causing...

RefResolver.resolve_fragment() breaks nested relative references

@Julian This seems to be fixed on master branch...when are you planning on cutting a release for 3.0.0?

RefResolver.resolve_fragment() breaks nested relative references

nvm I'm dumb, could just grab pre-release! Great work!! Love jsonSchema ❤️

RefResolver.resolve_fragment() breaks nested relative references

@Julian makes sense, I'll see if I can simplify and anonymize our schema and JSON payload into something very concise that fails on 2.6.0 and works on 3.0.0

[FR] Error-prone check to unpack nested try/with constructors into compound statements

Sounds like the biggest annoyance with introducing this is the intermediary variable name colliding with variable names already declared in other scopes. Should it be allowed (or even convention) to...

[FR] Error-prone check to unpack nested try/with constructors into compound statements

That makes sense as we typically reserve the underscore-prefix for unused parameters. Hopefully something like `fisDelegate` is available...

Field filter from nested query

I can corroborate what @rouanes was saying, cc @etoulas. The "hacky" solution (which I think is an elegant way to trick Metabase to allow you to declare the variables 😄...