Tito Dal Canton
Tito Dal Canton
@a-r-williamson you may want to watch out for the issue described in #3427.
Starting to look at this again. It seems codeclimate has picked up a few genuine issues, for example there is a reference to an undefined variable, and some docstrings have...
Or double the backslashes, `\` -> `\\`
I took another deep look through, and left some trivial comments and a more substantial one. I think those will be my last comments.
@spxiwh recommends moving the large pickle file to the pycbc-config repository. I agree the file is a bit large to keep here. Will look into that.
Some notes for posterity. Francesco and I spent some time looking into why the ISSO interpolant is needed, since it adds quite a bit of complexity. We reproduced an earlier...
I have been poking at the ISSO code a bit more, so here are a few more observations. First, I found that `PG_ISSO_solver()` is already quite fast, however the `RectBivariateSpline`...
It seems I cannot open a PR against this PR, but the change I propose is on this branch: https://github.com/titodalcanton/pycbc/tree/embright_remove_isso_interp.
How related is this to #3825?
Not really, I think this needs a bit more fiddling with `pycbc_plot_qscan`.