tison
tison
@JasonLunn may I ask how to run JRuby conformance test? `bazel test //jruby:conformance_test` gives: ``` ERROR: no such package 'jruby': BUILD file not found in any of the following directories....
Anyway, since JRuby delegates the building stage to ```java parser.merge(data.asJavaString(), ret.builder); ``` The enum name in the data can hardly be handled. I tend not to implement it for JRuby....
Pushed as f369bcb4e1d7d3d209f804c4a7e991f22ed48fd3 and 4bb02e09d373a21dde2e7522d6c29d16a4810603 for JRuby. No regressions locally.
Well. The last two commits don't help on `decode_json` (auto capitalize) for JRuby as described above.
@JasonLunn @deannagarcia I think ignore these cases for JRuby is OK. 1. If you define an Enum starting with lower case, it's already invalid for Ruby. We auto capitalize for...
@JasonLunn @deannagarcia @mkruskal-google any further comments here?
@JasonLunn thanks for your follow-ups: > Why is it that only JRuby needs expectation changes to the conformance tests, but CRuby doesn't? Please read https://github.com/protocolbuffers/protobuf/pull/10454#issuecomment-1246898576. The CRuby path is full...
Emmm..I may make a mistake here. That we can already use `resolve` to work with lower letter started enums. Let me comment on the original issue. https://github.com/protocolbuffers/protobuf/issues/1965#issuecomment-1259723485 Waiting for reviewers'...
Wait a minute. I think the original purpose is to define the constant following Ruby's rule. Let me try to narrow the change scope.
Updated. I think this patch is tidy now. All tests passed locally: ```bash rbenv global 3.1.2 bazel test //ruby:conformance_test rbenv global jruby-9.3.7.0 bazel test //ruby:conformance_test_jruby --define=ruby_platform=java --action_env=PATH --action_env=GEM_PATH --action_env=GEM_HOME --verbose_failures...