tison

Results 964 comments of tison

For JRuby, it may need more effort. And I may consider we finish the CRuby part first and following up for the JRuby part - I work on this part-time...

Addressed. The ruby unit test can be still failed because updates to the compiler seems not be used by the unit test in the same patch. I'm unsure if we...

@JasonLunn it seems `rake test` doesn't run JRuby tests. Can you show me how to do that? `rake test` should now passed but I don't make change on JRuby related...

For JRuby part, I switch the ruby version to `jruby-9.3.7.0` with rbenv and run `rake test`. It seems all tests passed locally now. ``` [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO]...

@deannagarcia reproduced and pushed a fix. It's because now Ruby will auto-capitalize enum names so that tests cannot find `moo` which becomes `Moo`. Previously, ruby compiler simply compiles `moo` as...

@deannagarcia @JasonLunn could you help with triggering the CI again? I run `bazel test //ruby:conformance_test` locally and all tests passed.

OK. I think I get the cause. Let me try to find a way adjust ruby tests only.

It's because we don't perform the same capitalize logic for decode json.

Fixed locally. Please rerun the tests. I think I should fix it for JRuby also, but I still don't find the related code.