Nicolas Williams

@spacesnottabs, I've merged https://github.com/openownership/register-sources-bods/pull/36 , and updating the locks has been taken care of elsewhere. I'd still value your opinion on whether you think that that patch will be sufficient,...

I caught up with @spacesnottabs about this today. The conclusion is that the linked PRs are not sufficient. Also needing to be done is: - [x] migrate existing BODS data...

### migrate existing BODS data in Elasticsearch With the latest extensions and fixes, the documents themselves in the BODS indexes in Elasticsearch appear to have migrated successfully. The `SC` vs...

Just recording that after discussion with @StephenAbbott, the decision was made to wait until the next monthly bulk data import before verifying whether this issue is fully fixed.

The monthly bulk data import hasn't fixed this. So further work is needed to investigate what can be done to ensure the statements get combined properly.

Migration `M20131205Resolve` was created, to allow subsets of statements to be forced to resolve freshly. This was run for GB SC311560, and although statements were updated, the still weren't ultimately...

I'm continuing to test this theory, but already it's looking like it's not quite correct. - Statements IDs are indeed generated including Register IDs. - I'm not sure that's desirable,...

I think I've found another issue. `replacesStatements` is excluded from the list of fields used to generate `statementID`. At first glance, this would seem to make sense, since it is...

Consider this specific example: ```json { "statementID": "13424564937546064062", "statementType": "entityStatement", "statementDate": "2023-06-19", "isComponent": false, "entityType": "registeredEntity", "name": "BREWDOG PLC", "incorporatedInJurisdiction": { "name": "United Kingdom of Great Britain and Northern Ireland",...