Nicolas Williams
Nicolas Williams
@StephenAbbott, @spacesnottabs, if I understand correctly, the related fixes were made as part of the v2 release. Is it now possible to verify the final testing for this ticket? Thanks.
Just noting that QC of this is still blocked by #181 , as far as I'm aware.
Noting also that the Third-Party Services account within Heroku is incorrect. This is likely accounting for the deploy account being incorrect. This needs to be reauthorised against an OO-controlled account.
I registered a test app and created a streaming key. Attempts to fetch data through it haven't been successful so far, however. Having checked Ingester PSC code to ensure the...
The Companies House Developer Hub console is back online. I attempted again to use a test application streaming key, but no data was returned. I then signed up for a...
I'm not sure we're actually using Rollbar in Register 2. This needs to be checked, and an approach agreed upon for this and any other failures.
The approach I've chosen is to log, reraise, and crash the program if the timepoint is invalid. This allows the failure to be apparent to monitoring, as well as to...
It appears that `PscStream` `read_stream` already extracts the company number, not from the self-link identifier, but from the resource URI: https://github.com/openownership/register-ingester-psc/blob/main/lib/register_ingester_psc/streams/clients/psc_stream.rb#L36-L38 This seems like a good approach, and it appears...
The streaming ingestion code has been updated to work with the later changes, and it seems to be working for streaming updates in development. I think deleted events or similar...
@spacesnottabs, I'm unsure about whether the linked PRs are sufficient, and whether it will be necessary to write a migration for existing Elasticsearch data. What do you think? I'm also...