Felix

Results 11 comments of Felix

> is it possible to test the change to check it won't regress? @tinylambda could you check this PR? what about removing the db constraints to avoid the MySQL's limitation,...

> > is it possible to test the change to check it won't regress? @tinylambda could you check this PR? > > what about removing the db constraints to avoid...

> @tinylambda Are you suggesting, removing the `max_length=200` restriction altogether? > > hmmm, not sure if that will have some other side-effects as a result. I means removing `unique=True`

> @tinylambda i dont think the issue is with the uniqueness constraint. its with the max length value being too large for mysql. You need this: https://stackoverflow.com/questions/1814532/1071-specified-key-was-too-long-max-key-length-is-767-bytes?answertab=active#tab-top unique=True will create...

> > @tinylambda i dont think the issue is with the uniqueness constraint. its with the max length value being too large for mysql. > > You need this: https://stackoverflow.com/questions/1814532/1071-specified-key-was-too-long-max-key-length-is-767-bytes?answertab=active#tab-top...

> @tinylambda I haven't had the chance to test the changes when we remove unique=True, but don't we actually want unique=True, since that will prevent PeriodicTask with duplicate names? What...

@andrewgodwin I can reproduce this by changing the chat example in document: ``` import json import asyncio import logging from channels.generic.websocket import AsyncWebsocketConsumer class ChatConsumer(AsyncWebsocketConsumer): def __init__(self, *args, **kwargs): super(ChatConsumer,...

> @tinylambda thanks for the extra info. Not sure yet if this is a usage issue we should document or something else, but I will reopen to investigate @carltongibson Thanks...

> > @tinylambda thanks for the extra info. Not sure yet if this is a usage issue we should document or something else, but I will reopen to investigate >...

> > > @tinylambda thanks for the extra info. Not sure yet if this is a usage issue we should document or something else, but I will reopen to investigate...