Tino Hager

icon indicating a website link https://www.nager.at icon indicating an email [email protected]

icon company @nager @mailtower-app icon location Austria icon location Professional Full Stack Software Developer. Maintainer of @nager projects. Founder of @Energiebiene and @mailtower-app.

Results 333 comments of Tino Hager

Add Hong Kong Public Holidays

@mkumar341 You are cordially invited to contribute here

Add Hong Kong Public Holidays

@mkumar341 Check the `Shift` method of [DateTimeExtension](https://github.com/tinohager/Nager.Date/blob/master/Src/Nager.Date/Extensions/DateTimeExtension.cs)

Hong Kong - Add Provider

Open Issues: According to Hong Kong laws, when a designated public holiday falls on a Sunday or on the same day of another holiday, the immediate following weekday would be...

Hong Kong - Add Provider

@samtrion Yes the sunday or day of another holiday move is open.

Local holidays in Portugal

I would be very happy if you would add the missing data. https://github.com/nager/Nager.Date/blob/master/Src/Nager.Date/PublicHolidays/PortugalProvider.cs

Chile - some holidays are modified

@Marcelo366 Did the holidays used to exist and they were abolished? Or was the information on Wikipedia wrong? https://en.wikipedia.org/w/index.php?title=Public_holidays_in_Chile&oldid=816214687

Chile - some holidays are modified

https://es.wikipedia.org/wiki/Fiestas_Patrias_de_Chile > Desde mediados del siglo XX, el 20 de septiembre ha sido feriado de facto en la Región de Coquimbo en 2014, 2016 y 2017 fue feriado legal en...

IsPublicHoliday(DateTime date, CountryCode countryCode) result inconsistent with GetPublicHoliday(DateTime startDate, DateTime endDate, CountryCode countryCode)

It is only a holiday in a county not in the full country. https://github.com/nager/Nager.Date/blob/4ae81585754dc034b5685bfcedf0c19a4448c9d0/Src/Nager.Date/PublicHolidays/GermanyProvider.cs#L145

IsPublicHoliday(DateTime date, CountryCode countryCode) result inconsistent with GetPublicHoliday(DateTime startDate, DateTime endDate, CountryCode countryCode)

In the other method you must check this field https://github.com/nager/Nager.Date/blob/4ae81585754dc034b5685bfcedf0c19a4448c9d0/Src/Nager.Date/Model/PublicHoliday.cs#L37

IsPublicHoliday(DateTime date, CountryCode countryCode) result inconsistent with GetPublicHoliday(DateTime startDate, DateTime endDate, CountryCode countryCode)

What would your implementation for the problem look like?