Valentin Gjorgjioski

Support for default wallet/fingerprint

6

Adding support for default wallet/fingerprint in config file.

URL sent as a parameter to the CriticalImages.Run seems to be incorrect when Pagespeed is running behind proxy

6

Hi, We have set the pagespeed to run behind proxy with Apache using ProxyPass and ProxyPassReverse. All works fine, but we noticed this - when ModPagespeedCriticalImagesBeaconEnabled is true/enabled, then this...

fix #39891 rate and amount should be Currency and not Int. > Please provide enough information so that others can review your pull request: > Explain the **details** for making...

### Information about bug rate and amount should be currency and not int. https://github.com/frappe/erpnext/blob/22291d32e6dfee445b15a2519e111a781b73abd5/erpnext/accounts/doctype/share_balance/share_balance.json#L202 https://github.com/frappe/erpnext/blob/22291d32e6dfee445b15a2519e111a781b73abd5/erpnext/accounts/doctype/share_balance/share_balance.json#L83 ### Module accounts ### Version latest ### Installation method None ### Relevant log output /...

Mandatory fields required in Account Company

1

### Information about bug https://discuss.frappe.io/t/mandatory-fields-required-in-account-company/106573 Adding Account in the chart should be possible even without company, since Parent account is specified - and it has a company that it belongs...

### Information about bug While it might working adding 1 for some currencies, with EUR this makes inconsistencies. 1 should be removed and is not necessary - it calculates wrongly....

### Information about bug It seems that this commit beside fixes, introduced some bug as well: https://github.com/frappe/erpnext/commit/ae613008be59334e5ff72882ef9d70355f56805e I will explain. E.g. setup parent and child company. delete 1 account from...

### Information about bug Bug was introduced here: https://github.com/frappe/erpnext/commit/dbf7a479b66bc31890b4a957564c7dfdfad49517 on line 114. Later (in the next loop iteration) an exception is thrown on line 58, as bank_ac_no is not known...

Add utf-8-sig when reading csv for import or do something else to remove BOM character

2

When reading CSV for import, from CSV file with BOM (which is default under Excel/MacOS ) the first column name is read together wit the BOM characters - therefore it...

Rate and amount should be currency, not Int. Fixes #39891