Jacqueline Lee

Results 9 comments of Jacqueline Lee

Thanks for the PR. I am also looking to adopt this functionality. As I am testing locally, I noticed that usage isn't supported. Here's an example of go_test where the...

@JamesMBartlett Any updates to this diff? We would like to incorporate this as part of our monorepo.

@fmeum Are there updates on https://github.com/bazelbuild/bazel/pull/16430 ? Would you suggest waiting for the upstream Bazel support before landing go_cross_test with limited functionalities?

> Hi! Thanks @tingilee for your contribution. Could you please write a test for this? Added tests and also include dependencies needed in the WORKSPACE.

@tpasternak > So I just don't fully understand why it is required to add all the dependencies to the WORKSPACE file. How do we use them? These dependencies where added...

We also ran into this issue, created https://github.com/bazelbuild/rules_go/pull/3662 to hopefully address it as suggested.

I just patched this in our repo and noticed that it didn't solve the parsing issue into test.xml. This issue will need to be reopened.

@sluongng I found that you've shared design thoughts before: https://github.com/bazelbuild/rules_go/issues/3529#issuecomment-1517707221 What would you recommend here?

> How does the binary get the path to the config file? In general, I'd like to propose that we set environment variable in rules_python to allow overrides: ``` coverage_env["PYTHON_COVERAGERC"]...